Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search][FTR] Fix / Improve tests #197264

Merged

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Oct 22, 2024

Summary

Closes #196981

  • Updated Search Index Details with data test suite to check for index documents first, this should help reduce flakey tests in MKI since we will ensure the documents are available before moving forward
  • Updated URL checks to use regex instead .equal with the mocked value. This should ensure the tests can pass in MKI and with integration testing
  • Removed the navigation check for the Maps page, this was causing intermittent failures due to a modal on the page.
  • Updated the getting started test suite to use developer role instead of admin

Checklist

@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner October 22, 2024 15:01
@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Search labels Oct 22, 2024
@TattdCodeMonkey
Copy link
Contributor Author

I will run both Flaky Test Runner and MKI tests before merging this.

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7207

[✅] x-pack/test_serverless/functional/test_suites/search/config.ts: 25/25 tests passed.

see run history

Updated the index details with data tests to check for documents first,
this test will retry and wait for documents to show up. In MKI we were
seeing the first test fail because the index details did not have any
data to show yet. This should help these test be a bit more flexible
since the refresh time on a release serverless instance is higher after
adding data.
Updates tests to use a regex for URL checks instead of expecting the
URLs to equal the mocked value exactly. This will allow these tests to
pass both locally and against a real cluster with the MKI tests.
Removing the navigation maps link click to improve reliability of tests.
The Maps page will sometime open an modal that has to explicitly closed.
For ES3 specifically we don't really want extra testing of the Maps
functionality, so just checking that the link is available should be
enough for us.
@TattdCodeMonkey TattdCodeMonkey force-pushed the test/fix-es3-onboarding-ftrs-mki branch from 3654982 to 25616df Compare October 22, 2024 19:48
@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) October 22, 2024 19:49
@TattdCodeMonkey TattdCodeMonkey merged commit 5034558 into elastic:main Oct 22, 2024
21 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #244712 succeeded c530e9409623e475b710fa3fa42063afaec4cf86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failsOnMKI: serverless security search_index_details and start_elasticsearch test suitea
4 participants